https://redmine.stoutner.com/https://redmine.stoutner.com/favicon.ico?16699090422022-11-06T01:30:49ZStoutner - RedminePrivacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25472022-11-06T01:30:49ZSoren Stoutnersoren@stoutner.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>Soren Stoutner</i></li></ul><p><a class="external" href="https://redmine.stoutner.com/issues/912">https://redmine.stoutner.com/issues/912</a> changed the opening of a bookmark in a new tab to also switch to that tab, so I won't address that here.</p>
<p>Regarding the issue of the system back button, I am generally reluctant to create options to modify the GUI, both because this creates a heavy maintenance burden (every code path that relates to each of these options has to be tested every time anything related to them changes) and because having too many options to modify the GUI can make the settings confusing to users.</p>
<p>I have made an exception for a few aspects of the GUI. For example, there are options in the settings to move the app bar to the bottom of the screen or to enable full-screen browsing mode.</p>
<p>In this case, I am not inclined to create an option. First, because I don't think many people would use it. Second, because it is not clear to me what the desired behavior should be. For example, using back to switch to a different tab doesn't seem like it would flow well in all circumstances, especially if a tab was opened by an intent from clicking a link in another app.</p>
<p>However, I will leave this feature request open for a while. If a large number of users would desire this feature and can agree on how it should behave I might be willing to reconsider.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25682022-11-11T16:00:42ZSam Jones
<ul></ul><p>Just updating you ...</p>
<p>I mistakenly killed 10 tabs in the last 6 days. Can you at least allow us to do what every browser in the world does ? When at the top of the history, the back button is greyed out and does nothing. Just make your back arrow do nothing under 'top of the history' condition. Or allow us this choice.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25692022-11-11T20:28:25ZSoren Stoutnersoren@stoutner.com
<ul></ul><p>The system back button should always do something in Android. It is unacceptable to have it not do anything. In addition, if a user taps the system back button enough times the final result should always be closing the app and going back to the launcher screen.</p>
<p>On Google Chrome, for example, the system back button navigates backwards in the tab history. If the tab it at the top of its history, then it closes the app.</p>
<p>The only difference between Google Chrome and Privacy Browser in this regard is that Privacy Browser does not save browsing data when it is closed. This is according to Privacy Browser's core privacy principles as described at <a class="external" href="https://www.stoutner.com/privacy-browser-android/core-privacy-principles/">https://www.stoutner.com/privacy-browser-android/core-privacy-principles/</a>. "From time to time I receive requests to add features to Privacy Browser that automatically store comprehensive histories across reboots or restore tabs on a restart. Although I can see the usefulness of such features, I am opposed to anything that automatically stores a browsing history just by engaging in normal browsing behaviors. Doing so makes it easy for malicious apps or devices made by companies like Cellebrite to extract browsing history from user devices without consent. As such, these type of features are unlikely to ever be implemented."</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25712022-11-14T08:53:08Zराही अखेराजोत
<ul></ul><p>I suggest that Privacy Browser should warn the user before closing a tab (make it optional).</p>
<p>Toast <strong>Press BACK button again to close this tab</strong></p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25732022-11-14T21:58:01ZSoren Stoutnersoren@stoutner.com
<ul><li><strong>Subject</strong> changed from <i>giving user choice of just what the Back arrow does under different conditions</i> to <i>Consider warning users before closing tabs</i></li></ul><p>I personally really dislike when apps display such messages. However, I wouldn't be completely opposed to adding such an option (disabled by default) if there was enough interest among users.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25742022-11-15T03:10:37ZSam Jones
<ul></ul><p>I'm not asking for any message. Simply ignore Back button if at top of history for this tab. I have the 'X' if I want to close tab.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25752022-11-15T03:31:14ZSoren Stoutnersoren@stoutner.com
<ul></ul><p>As mentioned previously, the back button should never do nothing in Android. You can read more about how the system back button should behave at the following URLs:</p>
<p><a class="external" href="https://developer.android.com/guide/navigation/navigation-principles">https://developer.android.com/guide/navigation/navigation-principles</a></p>
<p><a class="external" href="https://developer.android.com/guide/navigation/navigation-custom-back">https://developer.android.com/guide/navigation/navigation-custom-back</a></p>
<p><a class="external" href="https://developer.android.com/guide/components/activities/tasks-and-back-stack">https://developer.android.com/guide/components/activities/tasks-and-back-stack</a></p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25772022-11-16T17:24:08ZSam Jones
<ul></ul><p>Just looking now in a tab. Can't even tell on-screen that I am at the top of the history (so I can avoid an unintended closure of the tab). How about an Undo dialog .. that's in Chromium isn't it ?</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25782022-11-16T18:10:43ZSoren Stoutnersoren@stoutner.com
<ul><li><strong>File</strong> <a href="/attachments/231">Ghosted Back Entry.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/231/Ghosted%20Back%20Entry.png">Ghosted Back Entry.png</a> added</li><li><strong>Subject</strong> changed from <i>Consider warning users before closing tabs</i> to <i>Consider displaying an undo snackbar when a tab is closed</i></li></ul><p>You can tell if you are at the top of a WebView history when the back entry in the navigation menu is ghosted (see attached screenshot).</p>
<p>Android's WebView is based on the Chromium codebase, but Privacy Browser itself does not share any code with Chromium.</p>
<p>Having an undo snackbar instead of a warning would probably be a better idea. However, I still can't imagine that many users would end up enabling it, because it would be fairly annoying to have something pop up on the screen every time a tab was closed. Also, from a programming perspective, creating an undo option is very complicated. Not that I turn away from doing complicated things if they are important, but I don't often go down that route unless it is something that would actually be used.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=25792022-11-16T18:12:58ZSoren Stoutnersoren@stoutner.com
<ul></ul><p>I think the core of the issue is that the system back button is supposed to get whatever you are currently looking at on the screen off the screen. You are tapping the system back button but then being surprised when it does exactly what it is supposed to do. Irrespective of whatever value there is in implementing an undo option, after reading all of what has been posted here I come away convinced that the system back button is doing exactly what is should do in Privacy Browser.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=30882023-08-13T19:34:58Zv ...
<ul><li><strong>File</strong> <a href="/attachments/292">history-back-remains-indicator.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/292/history-back-remains-indicator.png">history-back-remains-indicator.png</a> added</li></ul><p>Number of times I was frustrated by accidentally closing a tab I shouldn't...<br />I respect your vision and understand that the back button should always go back.<br />I also understand that I can slide and see if it's the first entry (FIFO) of the history stack (deactivated "Back" button).<br />On the other hand, I wish there was a "magic" button that could bring back my tab.<br />I don't like the way that some browsers, like Firefox, propose to resurrect a vanished tab via the undo snackbar, because it demands a bit too much of my attention.<br />I also don't want to slide every time to check if I'm risking to close the current tab.<br />I really don't know how to tackle this problem in a clean way.</p>
<p>Idea/proposition :</p>
<p>Do you think it would be possible to display in the current tab name's rectangle, or elsewhere, the history index? It would show us if the tab is going to be closed. The option should, of course, be disabled by default. I also read that you are reluctant to add options to modify the GUI, but I wish you reconsider about this particularly annoying case for some of us.</p>
<p>See the image for a visual example of my proposition. The "2" means that the current tab is on its third history index (0-based). So we can go back 2 times before the tab is closed. So when the user will see "0", they will know the next click will close the tab. This is just an example, there could be many variants of it.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=30962023-08-14T14:24:19ZSoren Stoutnersoren@stoutner.com
<ul></ul><p>I don't think it would be a good idea to add a number to the tab because I think it clutters the interface. However, your comment got me thinking about the possibility of a visual indicator that back will close a tab. Perhaps it would work to change the tab background to a different color. I would have to think through a color change that wouldn't be too distracting, but I generally like the idea.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=30972023-08-14T15:21:50ZSoren Stoutnersoren@stoutner.com
<ul><li><strong>Subject</strong> changed from <i>Consider displaying an undo snackbar when a tab is closed</i> to <i>Change the background color of a tab when it can be closed by Back</i></li></ul><p>My first thought is to use the same background color that the app bar uses when a proxy is enabled. My only concern is that using the same background color for two elements right next to each other to indicate different things might be confusing to users.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=30982023-08-14T15:22:01ZSoren Stoutnersoren@stoutner.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>New</i></li></ul> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=31142023-08-14T23:45:30Zv ...
<ul></ul><p>The problem of using the same color is that if a user enables a proxy, the whole app bar (including all the tabs) switches to the "proxy" color, then the user wants to go back, (s)he reaches the top of the history, the background of the tab changes its color, but, the color being the same, the user is unable to see the difference.</p>
<p>What about using some kind of darker, not flashy, yellow, to indicate a warning?</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=31162023-08-15T16:46:17ZSoren Stoutnersoren@stoutner.com
<ul></ul><p>Currently the whole app bar background changes color when a proxy is used. But it would be fairly easy to only change the background of the URL bar and let the background of the individual tabs indicate if they will close on Back.</p>
<p>I am not sure how well this would work, or if it would feel distracting to have a patchwork of tab colors. It might look distracting. I would probably have to fully implement the idea and test it out for a while to even have a sense if it would be a good solution.</p> Privacy Browser Android - Feature #918: Change the background color of a tab when it can be closed by Backhttps://redmine.stoutner.com/issues/918?journal_id=31242023-08-15T21:42:10Zv ...
<ul></ul><p>If only the background color of the URL bar, and not the whole app bar, changes, when a proxy is selected, then it's OK for me.</p>
<p>I made the above suggestion about the yellow color only if the "proxy color" has to continue painting the whole app bar's background.</p>
<p>So I'm pretty in favour of your idea to use the same color on different app bar's areas.</p>