Project

General

Profile

Actions

Feature #1114

closed

Rewrite the filter list helpers in C++

Added by Soren Stoutner over 2 years ago. Updated 12 days ago.

Status:
Closed
Priority:
3.x
Start date:
11/02/2023
Due date:
% Done:

0%

Estimated time:

Description

Currently they are written in Kotlin, but with the recent nurfing of the Kotlin coroutine library for battery saving purposes it takes way too long (about 3 seconds) to parse the filter lists on startup. Rewriting the helpers in native code, like C++, might make a big difference.

Actions #1

Updated by Soren Stoutner over 2 years ago

  • Priority changed from 3.x to Next Release
Actions #2

Updated by Soren Stoutner over 1 year ago

  • Priority changed from Next Release to 3.x

I think I am going to hold off on this for the time being in favor of Feature #1207: Refactor Privacy Browser Android's filter list system to be more like the one implemented in Privacy Browser PC.

I am trying to decide if the performance improvement is worth the maintenance of native C++ code, especially because I won't know how much performance improvement there really is until I invest a lot of time into it.

Actions #3

Updated by Soren Stoutner 12 days ago

  • Status changed from New to Closed

The code seems to work quickly enough (especially the refactored code), so I don't see the need to implement this at this time.

Feature #1207: Refactor Privacy Browser Android's filter list system to be more like the one implemented in Privacy Browser PC

Actions

Also available in: Atom PDF