Project

General

Profile

Actions

Feature #1133

closed

Open internal web searches in adjacent tabs

Added by ask low about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Next Release
Start date:
12/08/2023
Due date:
% Done:

0%

Estimated time:

Description

Following up to #1100, same for the intents too.

Taking an example in your browsing session in the following order: some tabs you opened were amazon, some your project work, some tabs memes.
Let's say you're working on your projects (some middle tab). And you wanna access your mailing lists for patches. You head to your mail app & hit some reference link. And you end up opening that intent link as the last tab (memes).

Another example for web searches from the current tab:
https://shorturl.at/gsHJX

Actions #1

Updated by Soren Stoutner about 2 years ago

I just noticed that it might be possible to distinguish web searched from inside Privacy Browser and web searches from other apps.

https://developer.android.com/reference/android/content/Intent#EXTRA_REFERRER

I haven't checked to see if this field is populated on a web search, but if it is then you could treat internal web searches differently.

I think it is a good idea for web searches inside of Privacy Browser to open in adjacent tabs, so if I can do that I would be happy to implement it.

But I don't think it is a good idea for intents from other apps to open in adjacent tabs. Rather, I think that all intents from other apps should always open at the end of the tabs list. I would be willing to reconsider that opinion, but only if a large number of people felt differently.

If you like, we can repurpose this feature request to only be for web searches initiated inside of Privacy Browser and create another feature request for intents from external sources, leaving that one open to see how much interest it garners.

Actions #2

Updated by ask low about 2 years ago

If it's possible to distinguish between internal intents & external intents, then it's fine to implement only for internal btw.

But as I thought, there are also use cases for external intents to follow up the current tab. Cases where you need to have external intents to the last, we can manually visit the last tab & achieve it anyways.

As you follow kiss principle, I believe distinguishing between internal & external would further complicates the usage.

Actions #3

Updated by Soren Stoutner about 2 years ago

  • Subject changed from Open intent tabs adjacent to the current tab to Open internal web searches in adjacent tabs
  • Priority changed from 3.x to Next Release

I have retitled this feature request to reflect opening internal web searches in adjacent tabs. If you like, you may create another feature request to open all intents in adjacent tabs. If there are a lot of people who express interest in it, I might reconsider my opposition to such behavior, which I think would feel jarring in many instances.

Actions #4

Updated by ask low about 2 years ago

I think we'll let external intents go for now.

Actions #5

Updated by Soren Stoutner almost 2 years ago

Unfortunately, the EXTRA_REFERRER field (and every other Intent field that looked promising for disclosing the app that launched a web search) is null, making it impossible to determine from them which app initiated the search.

I am going to close this as unimplementable unless someone comes up with a way to determine where a web search originates.

Actions #6

Updated by Soren Stoutner almost 2 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF