Privacy Browser Android

Instead of using the opened new tab, pb replaces the farthest right tab with the one searched from the url bar.

I'll have to take a look and see if I can figure out what is going on.

@ask low, can you please test this alt build of Privacy Browser to see if it resolves the problem for you? You can install it alongside your existing Privacy Browser. The link below will expire in about a week.

https://nextcloud.stoutner.com/s/S2eqBQBZL2q5Eaq

Sorry about that. Try this version:

https://nextcloud.stoutner.com/s/BHLZ4b9Ziw4JNKW

You can close this in favor of #1136.

I'm not 100% sure yet that these two bugs have the same root cause. However, if the proposed fix handles both of them, then I will close this one as a duplicate of that.

I will have to think through some other possible solution.

Here is a new build you can test. Unlike the previous test version, this change has the potential to possibly break other things, particularly possibly not restoring tabs in the same order, but I have been running it for a few days without encountering any problems.

https://nextcloud.stoutner.com/s/BxtSX3NczFQiLyc

Like usual, this link will expire after a few weeks. Please let me know if 1) this fixes your problem, and 2) you notice any regressions.

https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff;h=83a2b6e5635956bb940642e0e5beb47453145dc3;ds=sidebyside attempts to make some progress on this issue, although it might not fully resolve it.

Sure. You can provide alt builds to test.
Although, I currently don't daily drive PB (as long as 1MB SISB crash exists). Moved all of my cookies into FOSS browser, but still hop on PB for anonymous surfing.

This is the build I already provided to test.

The commit was of yesterday right ? You probably provide some nextcloud shared link. Sorry but I couldn't find it.

The commit is the same as the build in #note-13.

I meant, you provided commit diff in #note-13, but not the build. Sorry but I think either I didn't understood how to get apk or you didn't provide it.

Should I have to compile apk like on my system ?

Sorry, I should have said that the commit in #note-13 is the same as the build in #note-12.

Ah ok. Btw that's 7 days ago. Maybe it's a different race condition then.

You know what? I think it's better you should revert back the new tab adjacent spawn patch altogether & then add newer commits one by one by making sure the race conditions are treated well?

I added the link to the test version and waited a while to see if there were any responses. As nothing was said, I added the commit about a week later.

It still isn't clear if this fixes the problem as you haven't commented either way. But I think this commit improves the code anyway, and my testing indicates it doesn't break anything, so I committed it.

I've reinstalled #note-12 just now & been manhandling the new tabs. Will let you know in couple days.

@ask low, have you encountered any problems with this test build?

Forgot to share my results here lmao. No new tab spawn issues until now.
But I'm not sure what #1136 issue is. Can you explain exactly what that is ? Caz the description defines similar meaning of this issue.