Project

General

Profile

Actions

Bug #563

open

Double-tap (to toggle full screen browsing mode) also "registers" as single click.

Added by Jaime T over 2 years ago. Updated 5 days ago.

Status:
New
Priority:
4.x
Start date:
04/30/2020
Due date:
% Done:

0%

Estimated time:

Description

Hi. I'm trying out "Full screen browsing mode" but if I do the double-click over what happens to be a link, then both the full screen browsing mode toggles and the link is followed.

Is it possible for the double-click to not register as a single-click as well?

Many thanks for the fantastic browser, btw - it's much appreciated.

Kind regards, Jaime

Actions #1

Updated by Soren Stoutner over 2 years ago

  • Assignee set to Soren Stoutner

Thanks for catching this bug. I would imagine there is some way to make it ignore the single tap, because when full screen browsing mode is disabled, double tapping cause the WebView to zoom to the text width, and in that scenario the single tap is ignored.

Actions #2

Updated by Soren Stoutner over 2 years ago

  • Priority changed from 3.x to Next Release
Actions #3

Updated by Soren Stoutner over 2 years ago

  • Priority changed from Next Release to 4.x

So, it turns out this is really complicated to control from outside of the WebView because of the way it handles ACTION_DOWN, single taps, and double taps. It might be possible to fix this in Privacy WebView, but it might also be too complex of a change to maintain in a rolling fork.

Actions #4

Updated by Jaime T over 2 years ago

Ok, that makes sense. Do you think it might be easier just to have an alternative way to toggle full-screen browsing mode (rather than double-tap)? (The question, of course, is "What?")

Actions #5

Updated by Soren Stoutner over 2 years ago

I am open to any other method of enabling and disabling full-screen browsing mode. It would be easy to add an entry to the navigation or options menu to start full-screen browsing mode, but if the app bar is hidden, it is hard to think of a method for exiting it.

Actions #6

Updated by Prince Cooper 5 days ago

Why would this gesture exist in the first place anyways. I don't consider this to be a useful at all.
I suggest to just tuck in Full Screen option under menu & remove this gesture completely.

No one usually uses features like these.

Actions #7

Updated by Soren Stoutner 5 days ago

1 - This is a fairly common gesture among apps, especially text-based apps as opposed to video playing apps, for entering and exiting full-screen mode.

2 - When in full-screen browsing mode (if the app bar is also hidden) how else would you recommend someone exit full-screen browsing mode?

3 - One of the interesting things I have learned in developing Privacy Browser is than many users are only aware of the features they find useful and often think that features they do not use themselves are not used by anyone. As the app developer, I can't just consider at how one person uses the app. I have to build it so that it works well for many different types of users.

Actions #8

Updated by Prince Cooper 5 days ago

1. As a browsing pov, it ain't that of a big deal anyways.

2. Android actually opens up navigation bar when swiped from below. So I don't think pb's full screen as a big issue.

3. I can understand this. It's a job of any dev to consider majority of the user requests. But having gesture to a full screen affects others workflow too.
There's also double tab to zoom which is a default behaviour of Android webview.

Actions #9

Updated by Soren Stoutner 5 days ago

Prince Cooper wrote in #note-8:

1. As a browsing pov, it ain't that of a big deal anyways.

It is to some people.

2. Android actually opens up navigation bar when swiped from below. So I don't think pb's full screen as a big issue.

That has not been my experience with Android. Have you tried using the feature in Privacy Browser?

Note that it can be possible to open the drawer when swiping from the left, but that can become more complicated when using the gesture navigation if the edge of the phone has a curved screen. For more information, see https://redmine.stoutner.com/boards/1/topics/243.

3. I can understand this. It's a job of any dev to consider majority of the user requests. But having gesture to a full screen affects others workflow too.

Actually, this only affects users who chose to enable full-screen browsing, which is disabled in the settings by default.

There's also double tab to zoom which is a default behaviour of Android webview.

Correct. When a user has enabled full-screen browsing mode they cannot use Android's double-tap to zoom functionality.

Actions

Also available in: Atom PDF