Project

General

Profile

Actions
Copy link

Feature #717

closed
SS SS

Expand the options for selecting a download provider

Feature #717: Expand the options for selecting a download provider

Added by Soren Stoutner over 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Next Release
Assignee:
Soren Stoutner
Start date:
05/22/2021
Due date:
% Done:

0%

Estimated time:

Description

This way, if no custom external app is installed, most devices will still download the file.

SS Updated by Soren Stoutner over 5 years ago Actions
Copy link
 #1

  • Priority changed from 3.x to Next Release

SS Updated by Soren Stoutner over 4 years ago Actions
Copy link
 #2

Note that if it uses Android's download manager it will be possible to pass in the cookies (to handle downloads from websites that require logins) but it will still not be possible to pass in proxy information.

See https://www.stoutner.com/privacy-browser-3-8/.

SS Updated by Soren Stoutner over 4 years ago Actions
Copy link
 #3

At the same time this is implemented, it would probably be a good idea to update the description in the settings to explain the limitation.

SS Updated by Soren Stoutner almost 4 years ago Actions
Copy link
 #4

  • Priority changed from Next Release to 3.x

It turns out that almost every device has at least one other system app installed that can offer to download the file. My Pixel 5 has Google Chrome and Google Drive. My Samsung Galaxy Tab A7 has Google Chrome, Google Drive, and Samsung Internet. If these apps are completely disabled then Privacy Browser could detect that nothing is available and instead use the system download manager. However, I would consider this to be a very rare occurrence. For this feature to get much real-life use it would probably require an additional entry in the settings. I am inclined not to go that direction unless there are a significant number of users who request it.

SS Updated by Soren Stoutner almost 4 years ago Actions
Copy link
 #5

This feature could be implemented by including a modified version of the code that was removed in https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff;h=8f7e9b7db429568e26f00bc2eef88402d722bec7.

It would need to use the SAF (Storage Access Framework) and the `setDestinationUri` method from https://developer.android.com/reference/android/app/DownloadManager.Request.

SS Updated by Soren Stoutner almost 4 years ago Actions
Copy link
 #6

The settings description has already been somewhat updated. It might not need any further modification.

SS Updated by Soren Stoutner almost 3 years ago Actions
Copy link
 #7

  • Priority changed from 3.x to Next Release

SS Updated by Soren Stoutner over 2 years ago Actions
Copy link
 #8

  • Subject changed from Make downloading with an external app fallback to using Android's download manager to Expand the options for selecting a download provider

I decided to make this a list in the settings with the following options:

Privacy Browser
Android's download manager
External app

Actions
Copy link

Also available in: PDF Atom