Project

General

Profile

Actions

Feature #885

closed

Consider deleting the service worker directory after every page loads

Added by Soren Stoutner about 2 years ago. Updated 9 months ago.

Status:
Closed
Priority:
Next Release
Start date:
08/08/2022
Due date:
% Done:

0%

Estimated time:

Description

Currently this is only done in Incognito Mode, but it might be a good idea to always do it if it doesn't cause significant problems with websites.

See https://redmine.stoutner.com/boards/1/topics/227.

Actions #1

Updated by Soren Stoutner about 2 years ago

It looks like recent versions of WebView have moved the Service Worker directory to `/data/data/com.stoutner.privacybrowser.standard/app_webview/Default/Service Worker`, so the old command that was deleting the service worker directory every time a page finished loading in Incognito Mode wasn't working.

Actions #2

Updated by Soren Stoutner about 2 years ago

Testing indicates that the files are not deleted if they are in use. So, for example. loading forum.f-droid.org populates files inside of Service Worker and they are not deleted as long as the user is at that site. However, the next site that finishes loading after leaving forum.f-droid.org deletes the Service Worker directory.

Actions #3

Updated by Soren Stoutner about 2 years ago

  • Status changed from New to Closed

After testing this for a while I have encountered no problems.

Implemented in commit https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff;h=89d388e324a3b9f719c70e590cfbaf866f727092.

Actions #4

Updated by ask low 9 months ago

It does break some websites like tutanota for example. Although the mail service do have an android client, I'm not sure what other sites like this use Service Worker.

Actions #5

Updated by Soren Stoutner 9 months ago

What was your testing methodology to determine that there was a problem?

Actions #6

Updated by ask low 9 months ago

Apologies. I forgot to enable DOM Storage for tuta & it then worked normally. Not a Service Worker issue btw.

Actions #7

Updated by Soren Stoutner 9 months ago

Thanks for the quick response. :)

Actions

Also available in: Atom PDF