Project

General

Profile

Actions
Copy link

Bug #1020

closed

Unencrypted Website dialog sometimes erroneously pops up

Added by Soren Stoutner over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Next Release
Assignee:
Soren Stoutner
Start date:
06/16/2023
Due date:
% Done:

0%

Estimated time:

Description

This sometimes happens when an intent is opening a new tab while the browser is being restored. I think the problem is that all the logic that was added to restore the correct page for ViewPager2 during restart is sometimes selecting the tab twice (before an encrypted URL has been loaded), causing the dialog to appear.

The solution should be to have the view pager check to see if the tab is already selected before selecting it again.

Files

Suprious Encryption Dialog.png (239 KB) Suprious Encryption Dialog.png Soren Stoutner, 06/30/2023 03:16 PM
Actions
Copy link
 #1

Updated by Soren Stoutner over 1 year ago

This happened to me a few times, but now I am unable to replicate the problem.

Actions
Copy link
 #4

Updated by Soren Stoutner over 1 year ago

The previous fix was incomplete. I refactored the page changing code, which appears to have completely resolved the problem.

Fixed in commit: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff;h=6f53fabebc2ce78292a268e6ad0712dec8b6f3d9.

Actions
Copy link
 #5

Updated by Soren Stoutner over 1 year ago

That last fix still wasn't sufficient. Perhaps increasing the delay time that the SSL certificate won't display after restart will do it.

https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff;h=83b0beda5a1374f43e0ea07b7fad4adee9365ea9

Actions
Copy link

Also available in: Atom PDF