Project

General

Profile

Actions

Feature #1078

open

Add context menus to the bookmarks menu

Added by Soren Stoutner 7 months ago. Updated 2 months ago.

Status:
New
Priority:
1.x
Start date:
09/07/2023
Due date:
% Done:

0%

Estimated time:

Description

Currently the context menus only work on the bookmarks toolbar.

Konqueror has them working on both (except that they killed the context menu on items in the bookmark menu that aren't bookmarks).

Using setContextMenuPolicy(Qt::CustomContextMenu) doesn't work because it is overwritten by void KMenuMenuHandler::showContextMenu(QMenu *menu, const QPoint &pos) in kmenumenuhandler_p.cpp.

https://github.com/KDE/kxmlgui/blob/master/src/kmenumenuhandler_p.cpp

Konqueror may be able to work around this because they don't base their system directly on KXmlGuiWindow, but rather `KParts::MainWindow` and `KonqFrameContainerBase`.

They do this with QMenu *KonqBookmarkMenu::contextMenu(QAction *action) in kbookmarkmenu.cpp, which overrides the protected function in KBookmarkMenu.

https://api.kde.org/frameworks/kbookmarks/html/kbookmarkmenu_8cpp_source.html

Actions #1

Updated by Soren Stoutner 6 months ago

This is related to Feature #1091: Consider adding menu entries for editing folders in the bookmarks menu, but much more difficult to impliment.

Actions #2

Updated by Soren Stoutner 6 months ago

  • Priority changed from 1.x to Next Release
Actions #3

Updated by Soren Stoutner 2 months ago

  • Priority changed from Next Release to 1.x

I am going to wait until the transition to Qt 6 to look at this more closely.

Actions

Also available in: Atom PDF