Project

General

Profile

Actions

Feature #1169

closed

Color the status bar on proxy change

Added by ask low 10 months ago. Updated 5 days ago.

Status:
Closed
Priority:
Next Release
Start date:
02/16/2024
Due date:
% Done:

0%

Estimated time:

Files

sandwiched.png (38 KB) sandwiched.png ask low, 02/16/2024 10:05 AM
Actions #1

Updated by ask low 10 months ago

Continuing from

https://redmine.stoutner.com/boards/1/topics/469?r=475#message-475

I believe coloring the status bar would even out the interface.
Because right now, the appbar with a proxy, looks like it is sandwiched between status bar & webpage.

Actions #2

Updated by Soren Stoutner 10 months ago

  • Status changed from New to Closed

I am going to close this feature request for now, as I believe the current behavior is the correct behavior. If there are a large number of people on the forum who feel differently I might reconsider.

Actions #3

Updated by ask low 10 months ago

I mean just look at this Soren. Are you sure this looks correct ?

Actions #4

Updated by Soren Stoutner 10 months ago

Yes, it does to me. As I mentioned in the forum, if you think this should change, you need to suggest another way to visually indicate to the user that proxying is enabled. This indication should be visible at all times that the app bar is visible.

The reason why I like this is because it matches well with domain settings. When domain settings are applied the URL background changes color to indicate that the settings for that domain are modified. When proxying is enabled the entire app bar background changes color to indicate that all information sent by the app is going through the proxy. Among other things, this works well because you can have both proxying and domain settings applied at the same time and the visual indicators don't interfere with each other.

Actions #5

Updated by ask low 10 months ago

You are right about both proxy & domain setting color mechanisms. I am not denying that. But I'm suggesting to include status bar into the same coloring mix too. That would look consistent throughout the upper portion of the browser, is what I'm saying.

Actions #6

Updated by Soren Stoutner 10 months ago

  • Status changed from Closed to New

Oh, I had misunderstood. I can see changing the status bar color to match the app bar being a good idea. I have reopened this feature request.

Actions #7

Updated by ask low 10 months ago

Tq. Btw you should read into the tracker issue carefully before jumping into conclusions. It is literally in the title description "status bar"
We all do mistakes mate ;D

Actions #8

Updated by Soren Stoutner 10 months ago

You are right. I will make sure to read more carefully in the future.

Actions #9

Updated by ask low 2 months ago

Hi. Can I know the status of this enhancement? This is supposed to be a simple UI change.

Just need to color the status bar too while proxy change, so that it blends well with url bar & tab bar.

Actions #10

Updated by Soren Stoutner 2 months ago

It's a low priority. I will get around to it eventually before finishing the 3.x series. If more than one user things it is important, that will raise the priority.

Actions #11

Updated by Soren Stoutner 2 months ago

  • Priority changed from 3.x to Next Release

On second thought, since you asked, I will bump this up to the next release.

Actions #12

Updated by Soren Stoutner 2 months ago

  • Status changed from New to Closed

I like how this visually indicates proxying is enabled even when the app bar is scrolled off the screen.

Implemented in commit: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff;h=17032aa3bf7d84942436b254cf5ebffc2b41ce46;ds=sidebyside.

Actions #13

Updated by Soren Stoutner 5 days ago

It should be noted that Android has removed the ability to change the status bar color beginning in Android 15 (API 35).

https://developer.android.com/reference/android/view/Window#setStatusBarColor(int)

The workaround of drawing a colored background behind the status bar is probably more effort than I am inclined to devote to this feature.

Actions #14

Updated by ask low 5 days ago

That's interesting. Android is turning out to be more and more restrictive I guess.

Just today, I was thinking of how to use third party gestures on a third party launcher, which seemed to work amazingly before. They borked it perfectly.

Actions #15

Updated by Soren Stoutner 5 days ago

I created Feature #1239: Consider coloring the status bar while proxying on Android 15 (API >= 35) as a reminder to look again in the future to see if implementing this in API >= 35 becomes easy again.

Actions

Also available in: Atom PDF