Feature #1169
closedColor the status bar on proxy change
Added by ask low 10 months ago. Updated 5 days ago.
0%
Files
Updated by ask low 10 months ago
Continuing from
https://redmine.stoutner.com/boards/1/topics/469?r=475#message-475
I believe coloring the status bar would even out the interface.
Because right now, the appbar with a proxy, looks like it is sandwiched between status bar & webpage.
Updated by Soren Stoutner 10 months ago
- Status changed from New to Closed
I am going to close this feature request for now, as I believe the current behavior is the correct behavior. If there are a large number of people on the forum who feel differently I might reconsider.
Updated by ask low 10 months ago
- File sandwiched.png sandwiched.png added
I mean just look at this Soren. Are you sure this looks correct ?
Updated by Soren Stoutner 10 months ago
Yes, it does to me. As I mentioned in the forum, if you think this should change, you need to suggest another way to visually indicate to the user that proxying is enabled. This indication should be visible at all times that the app bar is visible.
The reason why I like this is because it matches well with domain settings. When domain settings are applied the URL background changes color to indicate that the settings for that domain are modified. When proxying is enabled the entire app bar background changes color to indicate that all information sent by the app is going through the proxy. Among other things, this works well because you can have both proxying and domain settings applied at the same time and the visual indicators don't interfere with each other.
Updated by Soren Stoutner 10 months ago
- Status changed from Closed to New
Oh, I had misunderstood. I can see changing the status bar color to match the app bar being a good idea. I have reopened this feature request.
Updated by Soren Stoutner 10 months ago
You are right. I will make sure to read more carefully in the future.
Updated by Soren Stoutner 2 months ago
It's a low priority. I will get around to it eventually before finishing the 3.x series. If more than one user things it is important, that will raise the priority.
Updated by Soren Stoutner 2 months ago
- Priority changed from 3.x to Next Release
On second thought, since you asked, I will bump this up to the next release.
Updated by Soren Stoutner 2 months ago
- Status changed from New to Closed
I like how this visually indicates proxying is enabled even when the app bar is scrolled off the screen.
Implemented in commit: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff;h=17032aa3bf7d84942436b254cf5ebffc2b41ce46;ds=sidebyside.
Updated by Soren Stoutner 5 days ago
It should be noted that Android has removed the ability to change the status bar color beginning in Android 15 (API 35).
https://developer.android.com/reference/android/view/Window#setStatusBarColor(int)
The workaround of drawing a colored background behind the status bar is probably more effort than I am inclined to devote to this feature.
Updated by Soren Stoutner 5 days ago
I created Feature #1239: Consider coloring the status bar while proxying on Android 15 (API >= 35) as a reminder to look again in the future to see if implementing this in API >= 35 becomes easy again.