Project

General

Profile

Actions

Feature #1174

open

Provide share link in "Save URL" dialog

Added by ask low about 2 months ago. Updated about 2 months ago.

Status:
New
Priority:
3.x
Start date:
02/25/2024
Due date:
% Done:

0%

Estimated time:

Files

sharing-link-while-saving.mp4 (12.2 MB) sharing-link-while-saving.mp4 ask low, 02/25/2024 07:30 AM
share-in-save-url.png (52.7 KB) share-in-save-url.png ask low, 02/26/2024 09:41 AM
double-tap.mp4 (1.87 MB) double-tap.mp4 ask low, 02/26/2024 10:10 AM
Main Context Menu.png (218 KB) Main Context Menu.png Soren Stoutner, 02/26/2024 10:16 AM
Overflow Context Menu.png (214 KB) Overflow Context Menu.png Soren Stoutner, 02/26/2024 10:16 AM
Invidious.png (325 KB) Invidious.png Soren Stoutner, 02/26/2024 10:27 AM
Actions #1

Updated by ask low about 2 months ago

Some downloads from some websites doesn't show the download links on their page & it's visible only while I download it.
In this case, there's no way to get the download link into the clipboard or share it with other application.

Under the Privacy Browser's download mechanism, provide Share option in the pool of Cancel & Save buttons too. So that we get the liberty to access the android's share interface with the download link.

Actions #2

Updated by ask low about 2 months ago

  • Subject changed from Provide share link in Share URL dialog to Provide share link in "Save URL" dialog
Actions #3

Updated by ask low about 2 months ago

Currently, the way I do this, is to hold the download link from text box of Save URL dialog & then there's share option in text edit tools.

This is very inefficient way. Because when the links are too big (that cross the screen real estate), they need to be holded multiple times inorder to get the text edit tools prompt.

Actions #5

Updated by Soren Stoutner about 2 months ago

  • Status changed from New to Closed

I am not aware of any way to do this. Usually when the download link isn't available it is because it is acquired by JavaScript or by passing through redirects. Initiating WebView's download logic goes through those processes and acquires the download link, sometimes at the expense of loading a different URL in the main page. I can't think of any way to acquire that information in the context menu.

Actions #6

Updated by ask low about 2 months ago

Oh you understood that way ? Not in the context menu. I meant in the Save URL page. The page just before you start saving / downloading files.
There are currently 2 options "Cancel" & "Save". Just suggesting you could add "Share" too, so that the link goes through android's native share interface, instead of downloading it.

Actions #8

Updated by Soren Stoutner about 2 months ago

What would be the advantage to this that can't be accomplished by simply copy and pasting the URL?

Actions #9

Updated by ask low about 2 months ago

What would be the advantage to this that can't be accomplished by simply copy and pasting the URL?

#note-3.

Actions #10

Updated by Soren Stoutner about 2 months ago

Doulbe-tap on the link and it will select the whole thing. That is a standard Android behavior.

Actions #11

Updated by ask low about 2 months ago

I'm not sure I'm able to follow.
It does show up on holding here. But I had to hold twice. It's basically very inefficient.

Updated by Soren Stoutner about 2 months ago

Yes, you double-tap it (tap it twice). It is a quick gesture that feels efficient to me.

Note that, in standard Android, the context menu that pops up has an overflow menu with a share option. For the small number of uses this would have, I think this is perfectly acceptable.

Actions #13

Updated by ask low about 2 months ago

As you can see my screen capture from #note-11, I did try double tapping multiple times & I literally run stock AOSP.

Here, holding works. But the screenshots you showed, had smaller URLs. Test with larger URLs. Like how I tried to download a stream from Invidious. In this case, the URLs overflow from the screen real estate and you're going to have problems spawning text toolbox popup.

Actions #14

Updated by Soren Stoutner about 2 months ago

Invidious works just fine for me with a double-tap.

Which AOSP build are you using?

Actions #15

Updated by ask low about 2 months ago

treble_arm64_bvN-userdebug 14 UQ1A.240205.004.B1 eng.ponces.20240206.111028 release-keys

Btw it does work but I have to hold multiple times here. I often share these links numerous times to my local player to stream them. It's like 20 to 30 times a day when I listen to podcasts & audio clips.

Once look into #note-4 screen capture & lemme know what I was doing wrong ?

Actions #16

Updated by Soren Stoutner about 2 months ago

I would recommend that you submit a bug report to treble and ask them to fix standard Android double tapping to select all text.

Actions #17

Updated by ask low about 2 months ago

Sure. But wouldn't it be viable to provide sharing of the link in the dialog ? I know it becomes a duplicate.
Due to the open source nature of AOSP, many other forks & clones tend to modify these behaviours. Even though I'm on AOSP it's still very ineffective to hold these lengthy links repetitively each time.

I even remember using phhusson's AOSP he even provides pure stock android without any change. This even happened on that too. I think double tapping is only Pixel Exclusive.

Actions #18

Updated by Soren Stoutner about 2 months ago

  • Status changed from Closed to New

You do have a point that adding an extra button to the doesn't take away much from the UI.

In regard to Treble and AOSP, based on the repository it looks like Treble is making quite a few changes to the upstream AOSP. Some of these are probably good, but some of these probably cause problems.

https://github.com/ponces/treble_aosp/tree/android-14.0/patches

Again, I would recommend you create a bug report with Treble asking them to fix the standard behavior of selecting all the text in a TextEdit (I tested a few older or non-Pixel devices and, depending on the version of Android, you might have to long-press instead of double-tap, but it still selected all the text and popped up a context menu with copy and share).

In general, I don't like to workaround buggy implementations in some random ROM. Rather, I prefer the ROM fix their behavior. But I might consider implementing this because the downsides to those will well-functioning ROMs is minimal (and because it wouldn't take much effort to code or maintain). As such, I have reopened the feature request and will mull it over in my mind.

Actions #19

Updated by ask low about 2 months ago

You have a point. Will definitely file this issue to the Treble.
Btw, regarding not implementing something it's already supported by native android, you already did that with "Share URL" in main menu Share option. We don't need this because one can easily hold URL in address bar & get the share from textbox tools too.
Same goes to "Open with Browser" caz it's there in text toolbar. There's a reason you've provided all these as a built-in feature.

Actions #20

Updated by Soren Stoutner about 2 months ago

Neither of those entries do the same thing as sharing from the URL bar. Open with Browser displays a significantly different interface than the general share option, and Share URL shares additional information, so that if you share to an email program it will populate both the subject and the body of the email.

As such, I don't think either of those examples is really a good fit for what we are discussing here.

Actions #21

Updated by Soren Stoutner about 2 months ago

As a general recommendation, please try to do a bit more research before you post in one of these feature requests. I spend so much time responding to your comments that it is diminishing the amount of time I can spend programming future versions of Privacy Browser. It would be better if you spent a bit more time before you post to make sure that what you say will be truly helpful.

Actions #22

Updated by ask low about 2 months ago

Absolutely. #1174 & #1175 were just to enhance the features that were already existed. And don't request anything new or try to address any bugs.
Will not open any tickets of least concern & let you work on bigger bugs/features.

Actions

Also available in: Atom PDF