Bug #1222
closedDialogues are too big
0%
Description
Most, if not all, dialogue windows are too large, at least for my screen (22', 1080p). “Domain settings” is an example: the buttons lie below the bottom of the screen, which must be resized in order to reach them. “Filter Lists > Requests” is another. The dialogue is so large that one must move it leftward for what seems like a complete screenful in order to reach the close button. This one cannot be resized.
Would it be possible to give them all sensible default sizes and then remember the state they were left in? Thank you.
Files
Updated by Soren Stoutner 3 months ago
- File Requests Dialog.png Requests Dialog.png added
- Status changed from New to Feedback
- Assignee set to Soren Stoutner
Regarding the Domain Settings dialog, there was a fix for the close button being pushed off the bottom of small screens in the 0.6.1 release. Is that the version you are testing?
https://www.stoutner.com/privacy-browser-pc/changelog-and-downloads/
The Requests dialog should not size itself larger than your screen (attached is a screenshot showing how it displays by default at 1920 x 1080). Can you provide more information about your testing environment, including the Desktop Environment you are using?
Updated by José Manuel García-Patos 3 months ago
Soren Stoutner wrote in #note-1:
Regarding the Domain Settings dialog, there was a fix for the close button being pushed off the bottom of small screens in the 0.6.1 release. Is that the version you are testing?
Yes, it is. I'm using XFCE on Slackware -current. My monitor has a resolution of 1920x1080.
Apparently the size of the windows is defined in the *.ui files. I modified the width and height of some of them, and they changed. The thing is, some of those sizes were really too big. The Domain Settings dialog was 1350px high, and the Request window was 2500px wide, which explained my issue. I haven't checked others, but I wouldn't be surprised if they were also too big. I don't know why those were the default dimensions, though.
Updated by Soren Stoutner 3 months ago
The default sizes are built to work correctly with 4K monitors with large fonts. On KDE, they will automatically shrink to fit the size of the available screen real estate. However, maybe there is a bug that causes this to not work correctly on Xfce. I will do a little bit of testing.
Updated by Soren Stoutner 3 months ago
- Status changed from Feedback to Closed
I was able to replicate the problem on Xfce. Specifically, there are two issues.
1. Dialogs are not being constrained to the available desktop real estate.
2. The Requests dialog cannot be resized.
I spent some time playing with Qt's various sizing options, but none of them made any difference in Xfce's behavior.
https://doc.qt.io/qt-6/qsizepolicy.html
That wasn't really surprising, as the current settings already create a window of any size up to the specified size constrained in the available screen real estate.
In regards to the second problem, I have no idea why the Requests dialog cannot be resized. It is created in the same was as the other dialogs that can be resized, like Settings.
I did some further testing on a number of desktop environments with the following results.
Five desktop environments exhibited no problems:
- KDE
- GNOME
- GNOME Flashback
- Cinnamon
- MATE
Three desktop environments exhibited problem 1, where the dialogs were not constrained within the available screen real estate:
- Xfce
- LXDE
- LXQt
Two desktop environments exhibited problem 2, where the Requests dialog could not be resized:
- Xfce
- LXQt
I found it interesting that LXDE exhibited problem 1 but not problem 2, leading me to believe the underlying cause is slightly different between them.
I found it even more interesting that LXQt had problems, as it is based on Qt (and thus I would assume it would handle Qt's window sizing system well).
But, in the end, the fact that the majority of desktop environments, including those based on GTK, did not have any problems leads me to believe this is not a bug in Privacy Browser, but in Xfce itself. As such, I would recommend you file a bug report with them.
Updated by Soren Stoutner 3 months ago
As a side note, in my testing of this issue I did discover a related bug in Privacy Browser that I will fix for the next release.