Project

General

Profile

Bug #250

Fix sliding drawer layouts on phones with notches

Added by Brian Toole over 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Next Release
Start date:
02/21/2018
Due date:
% Done:

0%

Estimated time:

Description

Finally got around to upgrading my phone, and I've noticed a minor display issue with my new Essential phone. Including a screenshot, but the display oddity is with the notification bar not being fully transparent when viewing the side menu. I don't know if it'll help, but also including a reference about the camera cutout guidelines: https://www.reddit.com/r/essential/comments/7amvxr/app_compatibility_with_camera_cutout_in_essential/


Files

Screenshot_20180221-093521.png (123 KB) Screenshot_20180221-093521.png Brian Toole, 02/21/2018 11:30 AM
Google Rewards.png (110 KB) Google Rewards.png Brian Toole, 02/21/2018 12:50 PM
Hermit.png (167 KB) Hermit.png Brian Toole, 02/21/2018 12:50 PM

History

#1

Updated by Soren Stoutner over 1 year ago

  • Tracker changed from Feature to Bug
  • Assignee set to Soren Stoutner

Brian,

Thanks for the bug report.

Looking at the screenshot, it appears that the Essential Phone has increased the status bar height to be greater than is standard, which is causing the issue. So Privacy Browser needs to add additional padding into the header of the navigation drawer to compensate.

Can you take a screenshot of another app that has a navigation drawer that slides below the status bar? For example, Google Docs has this behavior. I'm curious if there is a simple way to fix this that won't cause problems for other phones.

#2

Updated by Brian Toole over 1 year ago

Adding two screenshots, one of Hermit Lite Apps, and the other of Google Rewards. I suspect this isn't something that you'll really be able to fix, as there appear to be three main ways apps handle this notification bar.

1. Don't handle it, and instead give it a black bezel
2. Handle it like Hermit, and block that space off with a color that doesn't show anything else with it
3. Treat it the way Privacy Browser and Google Rewards do.

I think the third option is actually the most ideal option, but it's only really noticeable here because of where the word "Navigation" lines up against the notification bar. Unless the Essential phone gets a way to make that notification bar invisible, there's likely not much that can be done outside of implementing some sort of conditional theme behavior for this particular device, which would probably be messy.

If you happen to have any good ideas, I'd happily test them out for you, but I'd consider this a low priority compared to the other stuff on your list!

#3

Updated by Soren Stoutner over 1 year ago

With Android P, Google is planning to integrate support for atypical display types directly into the OS. That might make it easy to automatically adjust to this type of screen.

https://www.xda-developers.com/android-p-atypical-display-types-material-design-2/

If it doesn't, I can look at doing some manual overrides, but that would likely require creating separate options for each custom phone (something that could become quite time consuming).

The reason why the navigation header is shorter than that found on other apps is that on small screen I don't want users to have to scroll to access options.

For now, I think I will wait and see if Android P makes fixing the problem easy.

#4

Updated by Brian Toole over 1 year ago

Makes sense to me. I did have another thought - not sure if it'll quite impact this issue much, but it could be a handy piece of customization for Privacy Browser - perhaps a separate feature request. One thing that Hermit Lite Apps has is a Frameless mode in addition to the Full Screen mode. You can see the behavior in action in the second video on the URL here: https://hermit.chimbori.com/help/getting-started. Right around the 1:30 mark.

#5

Updated by Soren Stoutner over 1 year ago

There is already a feature request to scroll the app bar, which is similar to Hermit Lite Apps's frameless mode. It will likely be implemented as part of the 2.x series.

https://redmine.stoutner.com/issues/8

#6

Updated by Soren Stoutner 9 months ago

  • Subject changed from Notification Bar display oddity on Essential PH-1 to Fix sliding drawer layouts on phones with notches

Also available in: Atom PDF