Project

General

Profile

Actions

Feature #302

closed

Consider refactoring the blocklist helper

Added by Soren Stoutner almost 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Next Release
Start date:
07/03/2018
Due date:
% Done:

0%

Estimated time:

Description

Currently it returns a boolean on the `isBlocked()` method. It could be refactored to return a String[] on a `checkBlockList()` method. This would unify how whitelist and blacklist entries are handled. But I'm not sure it is the way to go. It might increase the complexity of handling user block lists as described in https://redmine.stoutner.com/issues/181, which will handle whitelist entries differently as whitelist hits will override entries in other blocklists (they are a global whitelist), which they don't do for the standard blocklists (which are local whitelists).

Actions

Also available in: Atom PDF