Project

General

Profile

Actions

Feature #469

closed

Open bookmark in new tab

Added by Soren Stoutner over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Next Release
Start date:
07/01/2019
Due date:
% Done:

0%

Estimated time:

Description

The biggest difficulty with this feature request if figuring out how to implement the GUI. Currently, long-pressing already does something in both the bookmarks drawer (edit bookmark) and the bookmarks activity (select bookmark). It is possible this feature could be enabled only for the bookmarks drawer by replacing the edit bookmark functionality. But I am not sure I want to go that route because I might miss easy access to edit bookmarks.

Suggestions would be welcome.

Actions #1

Updated by Anonymous about 5 years ago

Long pressing a bookmark could present a menu (maybe a drop-down) with features like "Open in new tab", "Edit" and "Delete"

Actions #2

Updated by Soren Stoutner about 5 years ago

Utilizing a context menu that appears after a long press is one option, but I am not sure I want to go that route because it adds an extra step. I am more inclined to replace the edit functionality (which would make it only available from the Bookmarks Activity and not from the Bookmarks Drawer). However, I'm not yet certain that is the direction I want to go. I'm going to let these ideas percolate a bit before making a decision.

Actions #3

Updated by Anonymous about 5 years ago

Replacing the edit menu could work, I personally don't use it too much. There could also be a switch in the settings changing the behavior of long-pressing a bookmark.

Actions #4

Updated by Soren Stoutner about 5 years ago

It would be possible to have a preference setting that modifies how this behavior functions. However, as a general rule, I like to minimize the number of preferences that modify the UI, because it complicates both the coding and maintaining of Privacy Browser, and it makes it more difficult for users to navigate the settings. So, for example, there are preferences for altering the number of icons in the app bar or to enable full screen browsing mode. But I don't feel like this feature rises to that level. So, I want to pick one solution that works for the majority of use cases.

Actions #5

Updated by Soren Stoutner about 5 years ago

  • Priority changed from 3.x to Next Release
Actions #6

Updated by Soren Stoutner almost 5 years ago

  • Status changed from New to Closed

I have replaced the editing of bookmarks with a long-press in the bookmarks drawer by opening the bookmark in a new tab in the background. This works for the use case of a person who would like to open multiple bookmarks at one time and then browser through them at their leisure.

Implemented in commit https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=7f5c8f01744ffeb10e1c6450e571c0c5ea7d0ffc.

Actions

Also available in: Atom PDF