Project

General

Profile

Actions

Bug #839

closed

Toolbar cutting off bottoms of pages

Added by Jesse M 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Next Release
Start date:
04/02/2022
Due date:
% Done:

0%

Estimated time:

Description

The page is no longer resizing to make room for the bottom toolbar; rather it is overlaying it. I had to go to fullscreen to access the sign-in for this site. Guess I'll move the toolbar back up top for now.

No new hardware or OS. Galaxy S8+ Android 9/OneUI 1.0 current version of webview

Actions #1

Updated by Soren Stoutner 4 months ago

  • Status changed from New to Feedback
  • Assignee set to Soren Stoutner
  • Priority changed from 3.x to Next Release

What is an example URL that is giving you troubles? Does it matter if you enable scrolling of the app bar?

Actions #2

Updated by Jesse M 4 months ago

Settings manipulations don't seem to help. It causes issues on several sites, and like I mentioned, this site is an example. When I click on the hamburger button to log in (mobile version of page), the bottom toolbar appears even if it was hidden, and overlaps the bottom of the page. This occluded the login link at the bottom of the flyout sidebar thing. The toolbar must be removed with a full screen toggle or some other means to access it.

Actions #3

Updated by Soren Stoutner 4 months ago

  • Status changed from Feedback to In Progress

I think the problem was the elimination of the RelativeLayout as part of refactoring the bottom app bar in https://redmine.stoutner.com/issues/791.

https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=blobdiff;f=app/src/main/res/layout/main_framelayout_bottom_appbar.xml;h=694c810fe19592ebd8c045e1c134edc390794180;hp=e78bcc306c7887c72bded25c077f8ea610e36114;hb=1af1a793790badfcaf5497c82c4e7b70c7fdb69e;hpb=c906043ffe9b4d139e8d851e581a0eb46b935e42

The original purpose was to make the bottom app bar dodge snackbars while leaving the WebView stationary. While that is a nice effect, it isn't worth covering up the bottom of the WebView.

Actions #5

Updated by Soren Stoutner 4 months ago

The solution ended up being a whole lot more complicated than just modifying the layout. However, I think I have got it fixed.

There are a lot of complexities in relation to the top app bar, the bottom app bar, whether the app bar scrolls, if full screen browsing is engaged, and if the app bar is hidden in full screen browsing mode. However, I have done a bunch of testing and think I have everything working.

If you would like to test it out yourself you can download the test debug build at the link below. It can be installed alongside your current version of Privacy Browser. The link will expire after a few days. If you find a website that still has issues please let me know.

https://owncloud.stoutner.com/index.php/s/tT0XTo8ppwRFine

Actions

Also available in: Atom PDF