Added by Soren Stoutner over 1 year ago. Updated 3 months ago.
0%
Description
We had this problem several years ago and it was fixed, but it has recently started happening again. I am not sure what has changed. Perhaps it relates to the same WebView changes that are preventing domain font sizes from working properly.
This appears to only happen when a URL is loaded from a link in a website. To replicate, do a search for `Don't kill my app` and then click on the link to dontkillmyapp.com.
There is some additional information at #946.
This bug is intermittent, which means it probably relates to some sort of race condition.
The problem is caused because favorite icon requests are asynchronous. They are often (or perhaps always) not returned (or maybe even made) until after the webpage "finishes" loading. Sometimes, they can be significantly delayed.
If a website with a favorite icon is loaded and then another website without a favorite icon is loaded the favorite icon for the first website might be returned after the WebView has moved on to the second website. `onReceivedIcon` does not provide any mechanism to determine which URL requested the icon.
In the past, I was able to work around this a bit by discarding any icons received while a website is loading, as these will be from previous websites. However, sometimes a favorite icon is so delayed that it doesn't load until after the second website has finished loading, which leads to this bug.
There isn't really anything I can do to work around this in Privacy Browser, but I will submit an upstream bug to the Chromium project and see if they will address it there.
It looks like there are two existing upstream bug reports on this issue.
https://bugs.chromium.org/p/chromium/issues/detail?id=1082067
https://bugs.chromium.org/p/chromium/issues/detail?id=1341195