Project

General

Profile

Actions
Copy link

Bug #821

closed

Website loading reverts to the current site if the user agent changes

Added by Soren Stoutner about 3 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Next Release
Assignee:
Soren Stoutner
Start date:
03/23/2022
Due date:
% Done:

0%

Estimated time:

Description

We need a way to either delay changing of the user agent or disable the reload of the current website.

Files

Download all files
qt5-prevent-user-agent-reload.patch (1.26 KB) qt5-prevent-user-agent-reload.patch Soren Stoutner, 05/22/2023 06:48 AM
qt6-prevent-user-agent-reload.patch (1.21 KB) qt6-prevent-user-agent-reload.patch Soren Stoutner, 05/22/2023 06:48 AM
Actions
Copy link
 #1

Updated by Soren Stoutner about 3 years ago

  • Priority changed from Next Release to 1.x
Actions
Copy link
 #2

Updated by Soren Stoutner about 3 years ago

  • Tracker changed from Feature to Bug
Actions
Copy link
 #3

Updated by Soren Stoutner about 3 years ago

The solution was to use `load()` instead of `setUrl()`.

Fixed in commit https://gitweb.stoutner.com/?p=PrivacyBrowserPC.git;a=commitdiff;h=5daa7af456c7daa05b1a055932b5156ed1f88b00.

Actions
Copy link
 #4

Updated by Soren Stoutner about 3 years ago

  • Status changed from New to Closed
Actions
Copy link
 #5

Updated by Soren Stoutner almost 3 years ago

  • Status changed from Closed to New

Turns out this wasn't fixed by the previous commit.

Actions
Copy link
 #7

Updated by Soren Stoutner about 2 years ago · Edited

Actions
Copy link
 #8

Updated by Soren Stoutner about 2 years ago

  • Status changed from New to In Progress
Actions
Copy link Download all files
 #9

Updated by Soren Stoutner almost 2 years ago

The attached patches fix this issue. As Qt doesn't seem to want to implement it upstream, I will likely have to release PrivacyWebEngine earlier than anticipated.

Actions
Copy link
 #10

Updated by Soren Stoutner 2 months ago · Edited

Actions
Copy link
 #11

Updated by Soren Stoutner about 2 months ago · Edited

  • Status changed from In Progress to Closed
  • Priority changed from 1.x to Next Release

I was able to develop a tricky workaround involving canceling the load when the user agent changes and loading the new URL a second time. It's a bit hacky, but it happens so fast the user doesn't notice.

Fixed in commit: https://gitweb.stoutner.com/?p=PrivacyBrowserPC.git;a=commitdiff;h=1f7ac15b8de6d6321c6ee84b0178ef6dc8aa22da;ds=sidebyside

Actions
Copy link

Also available in: Atom PDF